Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Quickstart Failure #1075

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix for Quickstart Failure #1075

merged 1 commit into from
Jul 26, 2024

Conversation

DeepanshuA
Copy link
Contributor

Description

I debugged and found that the issue happened as, in isStarted func of sidecar.js, we are using GetMetadata API which had an Empty proto as request, while that was updated and wrapped inside a GetMetadataRequest().
But, I also found that it is already being used by v3.3.1 - so referred that and issue got resolved.

refer this run for validation: https://github.com/DeepanshuA/quickstarts/actions/runs/10109780799/job/27958376419

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1047

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Deepanshu Agarwal <[email protected]>
@DeepanshuA
Copy link
Contributor Author

ideally, we should:

  1. Not eat this exception just like in this case and let that be known - change In js-sdk
  2. we should use proper health endpoint instead of GetMetadata - in js-sdk

@DeepanshuA
Copy link
Contributor Author

@paulyuk @greenie-msft

@yaron2 yaron2 merged commit 09d1dcc into dapr:master Jul 26, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript Quickstart Tests/Checks FAIL (timing / sidecar not found?)
2 participants