Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Python test failure on Configuration API quickstart #1051

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jul 9, 2024

Test failures can happen running tests on 1.13 -> 1.14 because test relied on implicit ToString instead of inspecting .value off of the configuration item. Also ensure print consistently handles string interpolation.

Thank you @berndverst for educating me here.

Issue reference

#1050

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@paulyuk paulyuk added bug Something isn't working P1 language/python Pull requests that update Python code area/configuration labels Jul 9, 2024
@paulyuk paulyuk added this to the 1.14 milestone Jul 9, 2024
@paulyuk paulyuk self-assigned this Jul 9, 2024
@paulyuk
Copy link
Contributor Author

paulyuk commented Jul 9, 2024

@msfussell Python tests pass, ready to merge.

@paulyuk
Copy link
Contributor Author

paulyuk commented Jul 9, 2024

Merging. The JS and Tutorials failures are unrelated and have separate issues tracking.

@paulyuk paulyuk merged commit 915bc3e into dapr:master Jul 9, 2024
5 of 7 checks passed
@paulyuk
Copy link
Contributor Author

paulyuk commented Jul 9, 2024

@hhunter-ms docs-needed pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration bug Something isn't working docs-needed language/python Pull requests that update Python code P1
Projects
Development

Successfully merging this pull request may close these issues.

2 participants