Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve comparer of the original dictionary #935

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tomhreb
Copy link

@tomhreb tomhreb commented Aug 23, 2022

Signed-off-by: Tomas Hrebicek [email protected]

Description

Fixes issue #934

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@tomhreb tomhreb requested review from a team as code owners August 23, 2022 11:09
@halspang
Copy link
Contributor

@tomhreb - Thanks for opening this! I'm a little bit worried about removing case sensitivity though. What if people are depending on that?

I think this may be more what you're looking for #887?

@tomhreb
Copy link
Author

tomhreb commented Sep 19, 2022

@halspang No, I don't think #887 is related.

Without the case sensitivity, this functionality does not work. The original dictionary in the .net core library has this case sensitivity. I still regard this as a bugfix.

@tomhreb
Copy link
Author

tomhreb commented Dec 8, 2022

Hi @halspang, any idea if this will be approved?

Check that the base class in .net SDK really has StringComparer.OrdinalIgnoreCase.

https://github.com/dotnet/dotnet/blob/b8bc661a7429baa89070f3bee636b7fbc1309489/src/runtime/src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationProvider.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants