Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify workflow sample README #1210

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MregXN
Copy link
Member

@MregXN MregXN commented Dec 11, 2023

Description

Please reference the issue #1203 .

Signed-off-by: MregXN <[email protected]>
@MregXN MregXN requested review from a team as code owners December 11, 2023 14:37
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.53%. Comparing base (10ef818) to head (3d24bcc).
Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1210   +/-   ##
=======================================
  Coverage   66.53%   66.53%           
=======================================
  Files         171      171           
  Lines        5752     5752           
  Branches      626      626           
=======================================
  Hits         3827     3827           
  Misses       1776     1776           
  Partials      149      149           
Flag Coverage Δ
net6 66.52% <ø> (ø)
net7 66.52% <ø> (ø)
net8 66.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WhitWaldo WhitWaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a couple of tweaks to correct typos and preempt an easy mistake in the component requirements

To run this sample, in the first terminal window run the following command from the WorkflowTaskChaining directory
```
dotnet tun
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tun -> run

To run this sample, in the first terminal window run the following command from the WorkflowFanOutFanin directory
```
dotnet tun
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tun -> run

To run this sample, in the first terminal window run the following command from the WorkflowMonitor directory
```
dotnet tun
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tun -> run

To run this sample, in the first terminal window run the following command from the WorkflowMonitor directory
```
dotnet tun
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tun -> run

To run this sample, in the first terminal window run the following command from the WorkflowMonitor directory
```
dotnet tun
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tun -> run

@@ -13,8 +13,7 @@ This Dapr workflow example shows how to create a Dapr workflow (`Workflow`) and
## Optional Setup
Dapr workflow, as well as this example program, now support authentication through the use of API tokens. For more information on this, view the following document: [API Token](https://github.com/dapr/dotnet-sdk/blob/master/docs/api-tokens.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider also making it clear that there must be a storage component spec in their default component directory that includes actorStateStore: true or none of these examples will work as it'll fail to connect.

@WhitWaldo WhitWaldo added this to the v1.15 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants