Added unit test to validate JsonStringEnumConverter working as expected #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uring event publish Signed-off-by: Whit Waldo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1174 +/- ##
=======================================
Coverage 66.53% 66.53%
=======================================
Files 171 171
Lines 5752 5752
Branches 626 626
=======================================
Hits 3827 3827
Misses 1776 1776
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
halspang
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I prefer the JsonSerializer retaining the
stringoverintvalues for enums, so when I saw the bug reported in #1160 , I though I'd go ahead and tackle it. While I was unable to reproduce the experienced issue, I went ahead and added a unit test to the suite to prove out that this experience both works as-is and doesn't break going forward.Issue reference
Please reference the issue this PR will close: #1160
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
* [ ] Code compiles correctly* [ ] Extended the documentation