-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actor State TTL #1164
Merged
Merged
Actor State TTL #1164
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
de0a847
Actor state TTL support
JoshVanL 2f0cd2a
Updates Dapr version to 1.12.0
JoshVanL 0718834
Adds `ttlInSeconds` to example Dapr application
JoshVanL 9e4ada7
Use overloads when setting ttlInSeconds. Don't use nullable int
JoshVanL f3866e7
Use `DateTimeOffset?` rather than `DateTime?`
JoshVanL ea9999b
Use TimeSpan instead of int seconds, and only expose TTLExpireTime in
JoshVanL df5a6c0
Address feedback
JoshVanL 5922940
Fix TestDaprInteractor
JoshVanL 982d100
Revert github actions Dapr CI changes
JoshVanL 5bb19da
Register StateActor in E2E
JoshVanL c4135c7
Add State namespace
JoshVanL f57b549
Merge branch 'master' into actor-state-ttl
JoshVanL cd58e97
Fix Actor state test TTL exception check
JoshVanL 29265a0
Merge branch 'master' into actor-state-ttl
JoshVanL 9c381d6
Merge branch 'master' into actor-state-ttl
JoshVanL 6d5728d
Fix-up actor ttl state bugs and add unit tests
JoshVanL ba7ab5e
Return false in state provider if key is expired
JoshVanL 2967d4a
Ensure enough time has passed before checking key
JoshVanL d9d66b6
Merge branch 'master' into actor-state-ttl
JoshVanL a1b0b00
Merge branch 'master' into actor-state-ttl
halspang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// ------------------------------------------------------------------------ | ||
// Copyright 2023 The Dapr Authors | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// ------------------------------------------------------------------------ | ||
|
||
namespace Dapr.Actors.Communication | ||
{ | ||
using System; | ||
|
||
/// <summary> | ||
/// Represents a response from fetching an actor state key. | ||
/// </summary> | ||
public class ActorStateResponse<T> | ||
{ | ||
/// <summary> | ||
/// Initializes a new instance of the <see cref="ActorStateResponse{T}"/> class. | ||
/// </summary> | ||
/// <param name="value">The response value.</param> | ||
/// <param name="ttlExpireTime">The time to live expiration time.</param> | ||
public ActorStateResponse(T value, DateTimeOffset? ttlExpireTime) | ||
{ | ||
this.Value = value; | ||
this.TTLExpireTime = ttlExpireTime; | ||
} | ||
|
||
/// <summary> | ||
/// Gets the response value as a string. | ||
/// </summary> | ||
/// <value> | ||
/// The response value as a string. | ||
/// </value> | ||
public T Value { get; } | ||
|
||
/// <summary> | ||
/// Gets the time to live expiration time. | ||
/// </summary> | ||
/// <value> | ||
/// The time to live expiration time. | ||
/// </value> | ||
public DateTimeOffset? TTLExpireTime { get; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to keep
ActorStateResponse
as an internal type. How do we keep complication happy with this constraint?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philliphoff any ideas here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ActorStateResponse
is alreadyinternal
, no, or are you referring to the fact that this method ispublic
?IDaprHttpInteractor
andDaprHttpInteractor
are alreadyinternal
types, so nothing of them can be seen outside the SDK. Thepublic
on the method only applies to other types within the SDK. (Method visibility is always masked by visibility of the underlying type.)