Support case insensitive cloudevent payloads and forward cloudevent props s headers #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IliasP91
force-pushed
the
feature/forward-cloud-event-properties
branch
from
1c3a2a4
to
cb811e6
Compare
philliphoff
reviewed
Oct 3, 2023
philliphoff
reviewed
Oct 3, 2023
philliphoff
reviewed
Oct 3, 2023
philliphoff
reviewed
Oct 3, 2023
philliphoff
reviewed
Oct 3, 2023
philliphoff
reviewed
Oct 3, 2023
IliasP91
force-pushed
the
feature/forward-cloud-event-properties
branch
from
f1f6741
to
004a985
Compare
philliphoff
reviewed
Oct 6, 2023
philliphoff
reviewed
Oct 6, 2023
IliasP91
force-pushed
the
feature/forward-cloud-event-properties
branch
4 times, most recently
from
59fdc8b
to
b42cf63
Compare
Signed-off-by: Ilias Politsopoulos <[email protected]>
Signed-off-by: Ilias Politsopoulos <[email protected]>
Signed-off-by: Ilias Politsopoulos <[email protected]>
Signed-off-by: Ilias Politsopoulos <[email protected]>
Signed-off-by: Ilias Politsopoulos <[email protected]>
Signed-off-by: Ilias Politsopoulos <[email protected]>
Signed-off-by: Ilias Politsopoulos <[email protected]>
Signed-off-by: Ilias Politsopoulos <[email protected]>
IliasP91
force-pushed
the
feature/forward-cloud-event-properties
branch
from
b42cf63
to
c58b307
Compare
|
hi again, could someone have a look at this PR? I has been sitting there for a few months now... |
humandigital-michiel
pushed a commit
to humandigital-agency/dapr-dotnet-sdk
that referenced
this pull request
Oct 23, 2024
…rops s headers (dapr#1153) * forward cloudevent props Signed-off-by: Ilias Politsopoulos <[email protected]> * refactor middleware Signed-off-by: Ilias Politsopoulos <[email protected]> * add cloud event property filters Signed-off-by: Ilias Politsopoulos <[email protected]> * update string check Signed-off-by: Ilias Politsopoulos <[email protected]> * forward cloudevent props Signed-off-by: Ilias Politsopoulos <[email protected]> * refactor middleware Signed-off-by: Ilias Politsopoulos <[email protected]> * add cloud event property filters Signed-off-by: Ilias Politsopoulos <[email protected]> * update checks Signed-off-by: Ilias Politsopoulos <[email protected]> --------- Signed-off-by: Whit Waldo <[email protected]> Co-authored-by: Whit Waldo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the existing CloudEvent Middleware to:
This will make the middleware accept JSON payloads that are Pascal cases, as the default ASP Net core options already do.
And add the option to forward all the cloud event properties that are not automatically forwarded by the Dapr sidecar as headers. I had a use case where I wanted to read the type of the event (not just filter it) in my handler and currently there is no way of doing it as the middleware just unfolds the cloudevent envelope and discards it.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
UseCloudEvents()method, happy to create one of you think its valuable. I have extended one of the examples though)