Throw better exceptions when invalid actor interfaces are used. #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Hoff <[email protected]>
philliphoff
force-pushed
the
philliphoff-actor-interfaces
branch
from
433a1ff
to
ed23f26
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
- Coverage 66.53% 66.52% -0.02%
==========================================
Files 171 171
Lines 5752 5756 +4
Branches 626 628 +2
==========================================
+ Hits 3827 3829 +2
- Misses 1776 1777 +1
- Partials 149 150 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
halspang
reviewed
Nov 29, 2023
| @@ -14,6 +14,7 @@ | |||
| namespace Dapr.Actors.Client | |||
| { | |||
| using System; | |||
| using System.Globalization; | |||
There was a problem hiding this comment.
Since we're here, do you mind moving these imports outside of the namespace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verifies that actor interfaces used to create actor proxies actually:
IActorWhen interfaces are used that do not meet those requirements, a less cryptic error message is generated.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #859
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: