Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rev'ed Grpc.Net.Client PackageReference version for Dapr dotnet-sdk #1126

Merged
merged 6 commits into from
Jul 18, 2023

Conversation

MonkeyTennis
Copy link
Contributor

Description

Updated the version of Grpc.Net.Client used by Dapr dotnet SDK.

Issue reference

This is an aggregation of the following PRs already known to the Dapr dotnet SDK team:

#1123
#1122
#1121

Please reference the issue this PR will close: #[issue number]

See above

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@MonkeyTennis MonkeyTennis requested review from a team as code owners July 13, 2023 15:41
@halspang
Copy link
Contributor

@MonkeyTennis - Can you fix your DCO? git commit --am -s should do it.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #1126 (aa9e8b7) into master (c99475b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   67.22%   67.22%           
=======================================
  Files         170      170           
  Lines        5687     5687           
  Branches      605      605           
=======================================
  Hits         3823     3823           
  Misses       1723     1723           
  Partials      141      141           
Flag Coverage Δ
net6 67.15% <ø> (ø)
net7 67.15% <ø> (ø)
netcoreapp3.1 67.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MonkeyTennis MonkeyTennis force-pushed the BRADC/GrpcNetClientVersionRev branch from 95a4662 to 971da97 Compare July 14, 2023 07:19
shubham1172 and others added 5 commits July 14, 2023 08:33
* Update demo.http;

Signed-off-by: Shubham Sharma <[email protected]>

* Fix input

Signed-off-by: Shubham Sharma <[email protected]>

---------

Signed-off-by: Shubham Sharma <[email protected]>
Co-authored-by: halspang <[email protected]>
Signed-off-by: Bradley Cotier <[email protected]>
* [Workflow] Fix issue with ignored external event payload

Signed-off-by: Chris Gillum <[email protected]>

* Pushing missing commits

Signed-off-by: Chris Gillum <[email protected]>

* Remove unnecessary steps from itests.yml

Signed-off-by: Chris Gillum <[email protected]>

---------

Signed-off-by: Chris Gillum <[email protected]>
Signed-off-by: Bradley Cotier <[email protected]>
Signed-off-by: Bradley Cotier <[email protected]>
Signed-off-by: Bradley Cotier <[email protected]>
@MonkeyTennis MonkeyTennis force-pushed the BRADC/GrpcNetClientVersionRev branch from 362f7bf to 1a0ffa9 Compare July 14, 2023 07:33
@MonkeyTennis
Copy link
Contributor Author

@halspang done I think although it is my first DCO!

@MonkeyTennis
Copy link
Contributor Author

@halspang any thoughts on when this could go in?

@halspang halspang merged commit 574dc0c into dapr:master Jul 18, 2023
11 checks passed
onionhammer pushed a commit to onionhammer/dotnet-sdk that referenced this pull request Aug 22, 2023
…apr#1126)

Rev'ed Grpc.Net.Client PackageReference version for Dapr dotnet-sdk

Signed-off-by: Bradley Cotier <[email protected]>
Signed-off-by: Erik O'Leary <[email protected]>
@yaron2 yaron2 added this to the v1.12 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants