-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.13] Docs for PostgreSQL v2 state store #3996
Conversation
Fixes dapr#3911 Signed-off-by: ItalyPaleAle <[email protected]>
- component: PostgreSQL | ||
link: setup-postgresql | ||
- component: PostgreSQL v1 | ||
link: setup-postgresql-v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the old link is still available as alias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v1.md
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v1.md
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v1.md
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v1.md
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v1.md
Show resolved
Hide resolved
--- | ||
|
||
{{% alert title="Note" color="primary" %}} | ||
This is the v2 of the PostgreSQL state store component, which contains some improvements to performance and reliability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other reasons that you state here https://github.com/dapr/docs/pull/3996/files including
-
CockroachDB, YugabyteDB - Should users use this as the preferred component for these over https://docs.dapr.io/reference/components-reference/supported-state-stores/setup-cockroachdb/. If so, would be worth adding something into these component specs to say this
-
Is this the preferred version to use over the V1 component? If so, suggest saying this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CockroachDB will work but not sure if it should have its own component?
As for YugabyteDB, our tests show that it requires a bit of work at this stage. Specifically we need to make users enable the crypto extension for using the UUID generator function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ItalyPaleAle. A suggestion and comment
-
"This is the v2 of the PostgreSQL state store component, which contains some improvements to performance and reliability. It is recommended to use the V2 component over the V1."
-
Regarding "CockroachDB will work but not sure if it should have its own component?" - Should users ever use this component for CockroachDB then, or stay with the specific component https://docs.dapr.io/reference/components-reference/supported-state-stores/setup-cockroachdb/ ? Not sure what you mean by "CockroachDB will work but not sure if it should have its own component?" since it already has its own component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CockroachDB currently has its own documentation, not sure if we should have a v2 of that too
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v2.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny review
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v2.md
Outdated
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v2.md
Outdated
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v1.md
Outdated
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v1.md
Outdated
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v2.md
Outdated
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v2.md
Outdated
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v2.md
Outdated
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v2.md
Outdated
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v1.md
Outdated
Show resolved
Hide resolved
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v1.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Alessandro (Ale) Segala <[email protected]>
…tate-stores/setup-postgresql-v1.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Alessandro (Ale) Segala <[email protected]>
...docs/content/en/reference/components-reference/supported-state-stores/setup-postgresql-v2.md
Outdated
Show resolved
Hide resolved
…tate-stores/setup-postgresql-v2.md Signed-off-by: Alessandro (Ale) Segala <[email protected]>
Fixes #3911