Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.13] Docs for PostgreSQL v2 state store #3996

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

ItalyPaleAle
Copy link
Contributor

Fixes #3911

@ItalyPaleAle ItalyPaleAle requested review from a team as code owners January 31, 2024 22:55
- component: PostgreSQL
link: setup-postgresql
- component: PostgreSQL v1
link: setup-postgresql-v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the old link is still available as alias

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

---

{{% alert title="Note" color="primary" %}}
This is the v2 of the PostgreSQL state store component, which contains some improvements to performance and reliability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other reasons that you state here https://github.com/dapr/docs/pull/3996/files including

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CockroachDB will work but not sure if it should have its own component?

As for YugabyteDB, our tests show that it requires a bit of work at this stage. Specifically we need to make users enable the crypto extension for using the UUID generator function

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ItalyPaleAle. A suggestion and comment

  • "This is the v2 of the PostgreSQL state store component, which contains some improvements to performance and reliability. It is recommended to use the V2 component over the V1."

  • Regarding "CockroachDB will work but not sure if it should have its own component?" - Should users ever use this component for CockroachDB then, or stay with the specific component https://docs.dapr.io/reference/components-reference/supported-state-stores/setup-cockroachdb/ ? Not sure what you mean by "CockroachDB will work but not sure if it should have its own component?" since it already has its own component.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CockroachDB currently has its own documentation, not sure if we should have a v2 of that too

@msfussell msfussell added this to the 1.13 milestone Feb 1, 2024
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny review

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Alessandro (Ale) Segala <[email protected]>
hhunter-ms and others added 2 commits February 5, 2024 16:17
…tate-stores/setup-postgresql-v1.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Alessandro (Ale) Segala <[email protected]>
…tate-stores/setup-postgresql-v2.md

Signed-off-by: Alessandro (Ale) Segala <[email protected]>
@msfussell msfussell merged commit 5202af1 into dapr:v1.13 Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants