Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describing Kafka consumer behaviour when consuming from multiple topics #3931

Merged
merged 9 commits into from
Jan 11, 2024

Conversation

KrylixZA
Copy link
Contributor

@KrylixZA KrylixZA commented Jan 1, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This pull request documents the behaviour of Dapr consumer groups when consuming from multiple topics in Kafka. This updates the documentation to help users understand consumer group behaviour when subscribing to multiple topics to avoid the pitfalls of unevenly balanced consumer groups across topics.

Issue reference

Closes #3707.

@KrylixZA KrylixZA marked this pull request as ready for review January 1, 2024 16:10
@KrylixZA KrylixZA requested review from a team as code owners January 1, 2024 16:10
@KrylixZA
Copy link
Contributor Author

KrylixZA commented Jan 3, 2024

In light of the changes made in Dapr 1.12.3, this may not be necessary anymore. We should confirm the behaviour of a single pub/sub component being used to subscribe to multiple topics with Dapr 1.12.3 before either merging or abandoning this pull request.

@KrylixZA
Copy link
Contributor Author

KrylixZA commented Jan 5, 2024

Looking at the code changes in the fix Kafka consumer pull request on the components-contrib repo, my gut feel says the documentation herein is still relevant. Will confirm next week 👍

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. Yes this should remain true even after the v1.12.3 release, but best if you can confirm anyway.

@KrylixZA
Copy link
Contributor Author

KrylixZA commented Jan 8, 2024

Thanks for this contribution. Yes this should remain true even after the v1.12.3 release, but best if you can confirm anyway.

Hey Mark. Confirmed the updated documentation in this PR is still relevant in 1.12.3. Teams still need to configure multiple consumer groups (pub/sub component definitions) in order to effectively consume all partitions with all running pods 👍

This PR can merge when you are happy with it.

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Appreciate the great contribution to the docs

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review

@KrylixZA
Copy link
Contributor Author

Hey @msfussell / @hhunter-ms. Just an FYI: I am not authorised to merge PRs. When you are all happy and ready for this to merge, please would you mind completing the PR?

Ty :)

@msfussell msfussell merged commit 390de66 into dapr:v1.12 Jan 11, 2024
7 checks passed
@KrylixZA KrylixZA deleted the kafka-multiple-topic-consumer branch May 18, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka Pub/Sub documentation should note consumer group behaviour when subscribing to multiple topics
3 participants