-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describing Kafka consumer behaviour when consuming from multiple topics #3931
Conversation
Signed-off-by: Simon Headley <[email protected]>
Signed-off-by: Simon Headley <[email protected]>
In light of the changes made in Dapr 1.12.3, this may not be necessary anymore. We should confirm the behaviour of a single pub/sub component being used to subscribe to multiple topics with Dapr 1.12.3 before either merging or abandoning this pull request. |
Looking at the code changes in the fix Kafka consumer pull request on the components-contrib repo, my gut feel says the documentation herein is still relevant. Will confirm next week 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. Yes this should remain true even after the v1.12.3 release, but best if you can confirm anyway.
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md
Show resolved
Hide resolved
Hey Mark. Confirmed the updated documentation in this PR is still relevant in 1.12.3. Teams still need to configure multiple consumer groups (pub/sub component definitions) in order to effectively consume all partitions with all running pods 👍 This PR can merge when you are happy with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Appreciate the great contribution to the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick review
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md
Outdated
Show resolved
Hide resolved
…ubsub/setup-apache-kafka.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Mark Fussell <[email protected]>
Hey @msfussell / @hhunter-ms. Just an FYI: I am not authorised to merge PRs. When you are all happy and ready for this to merge, please would you mind completing the PR? Ty :) |
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This pull request documents the behaviour of Dapr consumer groups when consuming from multiple topics in Kafka. This updates the documentation to help users understand consumer group behaviour when subscribing to multiple topics to avoid the pitfalls of unevenly balanced consumer groups across topics.
Issue reference
Closes #3707.