Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workflow] Updates for Go SDK #3895

Merged
merged 28 commits into from
Feb 20, 2024
Merged

[Workflow] Updates for Go SDK #3895

merged 28 commits into from
Feb 20, 2024

Conversation

hhunter-ms
Copy link
Collaborator

@hhunter-ms hhunter-ms commented Dec 8, 2023 •
edited
Loading

Description

Update docs for Workflow being available in Go SDK

  • Go SDK presence in existing workflow docs
    • How to author
    • How to manage
    • Workflow overview
    • Workflow features and concepts // @mikeee will raise separate PR for this
    • Workflow patterns
    • Quickstart

Issue reference

PR will close: #3868

Related and dependent on this PR dapr/quickstarts#973

@hhunter-ms
prep for go workflow
bec3842 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms hhunter-ms added this to the 1.13 milestone Dec 8, 2023
@hhunter-ms hhunter-ms self-assigned this Dec 8, 2023
@github-actions GitHub Actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 14, 2023
@hhunter-ms hhunter-ms removed the stale label Dec 21, 2023
@github-actions GitHub Actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 27, 2023
@hhunter-ms hhunter-ms removed the stale label Jan 2, 2024
@hhunter-ms hhunter-ms requested a review from mikeee January 3, 2024 16:12
@mikeee mikeee mentioned this pull request Jan 5, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 9, 2024
@hhunter-ms hhunter-ms removed the stale label Jan 9, 2024
@msfussell msfussell mentioned this pull request Jan 11, 2024
Closed
@github-actions GitHub Actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 15, 2024
@github-actions github-actions bot closed this Jan 23, 2024
@yaron2 yaron2 reopened this Jan 23, 2024
@hhunter-ms hhunter-ms removed the stale label Jan 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Feb 1, 2024
@hhunter-ms hhunter-ms removed the stale label Feb 1, 2024
@mikeee
Copy link
Member

mikeee commented Feb 1, 2024

@mikeee will continue updating as code PRs are merged, but marking as ready for initial review. In the meantime, could you help provide:

Will review this PR with suggestions tomorrow 👍

mikeee
mikeee reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my initial set of comments

daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md Outdated Show resolved Hide resolved
daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't necessarily have an issue with this - more a comment on whether we should be including the actual quickstart code in the docs rather than somehow generating it from the source or more simply linking to it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think generating from source would be amazing - @msfussell do you know if we are able to do this at all?

daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md Outdated Show resolved Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md Outdated Show resolved Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit confused by the DO/DON'T commentS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeee This section provides examples to keep code deterministic and work around limitations... here's the context for this section: https://docs.dapr.io/developing-applications/building-blocks/workflow/workflow-features-concepts/#limitations

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be guidance in getting things like date time and guids etc correctly

daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-patterns.md Outdated Show resolved Hide resolved
@hhunter-ms hhunter-ms removed the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Feb 14, 2024
@hhunter-ms
Copy link
Collaborator Author

thanks @mikeee!

mikeee
mikeee approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

msfussell
msfussell reviewed Feb 17, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very comprehensive indeed. Caught a few issue that @mikeee you will need to take a look at.

daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-manage-workflow.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-manage-workflow.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-manage-workflow.md Outdated Show resolved Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be guidance in getting things like date time and guids etc correctly

hhunter-ms and others added 6 commits February 20, 2024 08:55
@hhunter-ms @marcduiker
Update daprdocs/content/en/developing-applications/building-blocks/wo…
d9cbcba 
…rkflow/howto-manage-workflow.md

Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Merge branch 'v1.13' into issue_3868
66b8bdd
@hhunter-ms @msfussell
Update daprdocs/content/en/developing-applications/building-blocks/wo…
e36ecc1 
…rkflow/howto-manage-workflow.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
updates per mark and marc
b9a8038 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Merge branch 'issue_3868' of https://github.com/hhunter-ms/docs into …
43dd7f7 
…issue_3868
@hhunter-ms @marcduiker
Update daprdocs/content/en/developing-applications/building-blocks/wo…
3c6c961 
…rkflow/howto-manage-workflow.md

Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
msfussell
msfussell approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeee Thanks for such a comprehensive PR! Appreciate this greatly!

@hhunter-ms hhunter-ms merged commit 19d4975 into dapr:v1.13 Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcduiker marcduiker marcduiker left review comments

@msfussell msfussell msfussell approved these changes

@mikeee mikeee mikeee approved these changes

Assignees

@hhunter-ms hhunter-ms

Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.
5 participants
@hhunter-ms @mikeee @marcduiker @msfussell @yaron2