Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dapr run command was listed incorrectly for Powershell users. It now has two different options for both Powershell and non-Powershell environments correctly ends in resources-path ../ (done in the get-started-component.md file), #3862

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

paianish62
Copy link

@paianish62 paianish62 commented Nov 11, 2023

In Section 3: Run the Dapr Sidecar, the --resources-path flag in the dapr run command was listed incorrectly. It now correctly ends in resources-path ../ for powershell users

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

in the get-started-component.md file, in Step 3: Run the Dapr sidecar, I added the correct command for PowerShell and non powershell environments. Changed dapr run --app-id myapp --dapr-http-port 3500 --resources-path . to dapr run --app-id myapp --dapr-http-port 3500 --resources-path ../ to make the command correct as Component Tutorial - "--resources-path" flag is incorrect when using Powershell.

Issue reference

#3858

…dapr run command was listed incorrectly. It now correctly ends in resources-path ../

Signed-off-by: Anish Pai <[email protected]>
@paianish62 paianish62 requested review from a team as code owners November 11, 2023 04:00
@paianish62 paianish62 changed the title he dapr run command was listed incorrectly. It now correctly ends in resources-path ../ (done in the get-started-component.md file) The dapr run command was listed incorrectly. It now correctly ends in resources-path ../ (done in the get-started-component.md file) Nov 11, 2023
yaron2
yaron2 previously approved these changes Nov 11, 2023
@yaron2
Copy link
Member

yaron2 commented Nov 11, 2023

In a non-Powershell env this would result in an error, because ../ would lead to the parent dir which isn't the correct dir that holds the component file

…apr run command in section 3 for running the Dapr Sidecar.

Signed-off-by: Anish Pai <[email protected]>
@paianish62 paianish62 closed this Nov 11, 2023
@paianish62 paianish62 reopened this Nov 11, 2023
@paianish62 paianish62 changed the title The dapr run command was listed incorrectly. It now correctly ends in resources-path ../ (done in the get-started-component.md file) The dapr run command was listed incorrectly for Powershell users. It now has two different options for both Powershell and non-Powershell environments correctly ends in resources-path ../ (done in the get-started-component.md file), Nov 11, 2023
@paianish62
Copy link
Author

I changed it so that there are both the Powershell and the non-PowerShell env commands on the page.

@hhunter-ms hhunter-ms merged commit d6acd94 into dapr:v1.12 Nov 13, 2023
7 checks passed
@yaron2 yaron2 added this to the 1.13 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants