Added example for retrieving bulk deserialized items in dotnet-sdk repo #3843
Conversation
|
After giving the contribution guide a second pass, I just noticed the warning indicating that all Dapr sample code should be in separate files and not inlined. I simply copied from what was already there, but if this is the preferred guidance, I'd be happy to redo the PR accordingly. |
.../content/en/developing-applications/building-blocks/state-management/howto-get-save-state.md
Outdated
Show resolved
Hide resolved
I can clarify this in the contributing guide, but this method in your PR is totally fine! Thanks for checking |
|
Stale PR, paging all reviewers |
|
I'm not entirely sure what the process is to keep from merging this just yet because while I've created the PR for the .NET SDK to implement the underlying, it hasn't itself been merged. Probably best to wait to merge this until that is itself merged too! |
hhunter-ms
added
waiting-on-code-pr
|
@WhitWaldo added a label for waiting on code! thanks for the heads up |
|
@hhunter-ms This is good to go as the code PR has been accepted and merged. |
…in dotnet-sdk repo. Signed-off-by: Whit Waldo <[email protected]>
…ate-management/howto-get-save-state.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
WhitWaldo
force-pushed
the
bulk-retrieval-deserialization
branch
from
5f98947
to
047e71c
Compare
hhunter-ms
removed
the
waiting-on-code-pr
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Added example to .NET documentation demonstrating changes implemented for dapr/dotnet-sdk#1172 alongside existing example. Really just copied/pasted the first example, added the Widget seen in the unit tests and tweaked to accommodate, so not a major change.
Issue reference
dapr/dotnet-sdk#1172