-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Docs to Show Azure App Configuration subscribePollInterval as ns #3595
Fix Docs to Show Azure App Configuration subscribePollInterval as ns #3595
Conversation
Signed-off-by: Tyler Siron <[email protected]>
d54b2d6
to
b190776
Compare
Signed-off-by: Tyler Siron <[email protected]>
Stale PR, paging all reviewers |
This is also a bug and we should fix this to be consistent with intervals type. Given this is alpha we can do the breaking change on the component. https://docs.dapr.io/reference/components-reference/supported-configuration-stores/ |
@tjsiron could you add a small note to this doc per Mark's comment:
Once added, we can merge this PR until we fix the bug! Also, please open an issue for this here: https://github.com/dapr/components-contrib/issues |
Stale PR, paging all reviewers |
I raised this tracking issue, dapr/components-contrib#2998 however we should push this PR with a comment and raise a new issue in the docs to track this issue when fixed |
Stale PR, paging all reviewers |
I opened a new issue for when the code has been updated. |
...e/components-reference/supported-configuration-stores/azure-appconfig-configuration-store.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…onfiguration-stores/azure-appconfig-configuration-store.md Signed-off-by: Hannah Hunter <[email protected]>
Description
When investigating the docs for the Azure App Configuration backend for configuration, I noticed the
subscribePollInterval
parameter is shown in1ms, 1m, 1h
format, but the golang code and the component definition here https://github.com/dapr/components-contrib/blob/master/configuration/azure/appconfig/metadata.yaml are expecting it in nanoseconds. Following the docs as is results in the following error:level=fatal msg="process component configstore error: [INIT_COMPONENT_FAILURE]: initialization error occurred for configstore (configuration.azure.appconfig/v1): azure appconfig error: can't parse subscribePollInterval field: strconv.Atoi: parsing \"1s\": invalid syntax"
Issue reference
I didn't create one, but I can if needed.