Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .net code tab on pubsub quickstart #3547

Closed
wants to merge 2 commits into from
Closed

Update .net code tab on pubsub quickstart #3547

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f43973d
Update pubsub-quickstart.md .net typo
paul42 Jun 14, 2023
93a73fc
Update pubsub-quickstart.md
paul42 Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion daprdocs/content/en/getting-started/quickstarts/pubsub-quickstart.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ dotnet build
Run the `checkout` publisher service alongside a Dapr sidecar.

```bash
dapr run --app-id checkout --resources-path ../../../components -- dotnet run
dapr run --app-id checkout --app-port 7006 --resources-path ../../../components -- dotnet run
Copy link
Contributor

@paulyuk paulyuk Jun 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea here, just two things:

  1. this change should be applied to the dapr run on order-processor - since that is the receiver of the POST/message. Is that what you meant to do?
  2. we should use port 7006 and match the code exactly in the pub_sub quickstart
  3. if you set up Run/debug via launch.json please have that patch and name match the code. However in future my plan is to use dapr.yaml and dapr run -f . for all of this which will remove tedious steps and issues.

The source of truth is here. @msfussell and @hhunter-ms note the docs have drifted a bit from readmes and I suggest we coordinate an update.
https://github.com/dapr/quickstarts/tree/master/pub_sub/csharp/sdk

```

In the `checkout` publisher, we're publishing the orderId message to the Redis instance called `orderpubsub` [(as defined in the `pubsub.yaml` component)]({{< ref "#pubsubyaml-component-file" >}}) and topic `orders`. As soon as the service starts, it publishes in a loop:
Expand Down