Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis): make auth profiles consistent for username/pwd #3565

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

sicoyle
Copy link
Contributor

@sicoyle sicoyle commented Oct 14, 2024

Description

Some redis components have the auth profile section for username/pwd, and others don't. I've ensured it's on all now.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@sicoyle sicoyle requested review from a team as code owners October 14, 2024 01:39
@yaron2
Copy link
Member

yaron2 commented Oct 14, 2024

Tests are failing

@yaron2 yaron2 merged commit 28d46f6 into dapr:main Oct 14, 2024
89 checks passed
elena-kolevska pushed a commit to elena-kolevska/components-contrib that referenced this pull request Oct 24, 2024
elena-kolevska pushed a commit to elena-kolevska/components-contrib that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants