Kubernetes components: add "kubeconfigPath" metadata #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to dapr#2992 Passing a kubeconfig path should happen via metadata and not CLI flags, which are deprecated. Also adds a "defaultNamespace" optional metadata to the Kubernetes secret store. Signed-off-by: ItalyPaleAle <[email protected]>
berndverst
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Looks good to me. Let's keep it open at least until tomorrow so @artursouza and/or @yaron2 also have a chance to see this.
berndverst
approved these changes
Aug 11, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2992
Passing a kubeconfig path should happen via metadata and not CLI flags, which are deprecated.
Also adds a "defaultNamespace" optional metadata to the Kubernetes secret store.