wasm: fixes test flake on Windows and strict mode #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ItalyPaleAle
approved these changes
Aug 4, 2023
|
/ok-to-test |
|
I’m only interested In the windows tests so I’ll stop all other tests |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 3df9a1c |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
ItalyPaleAle
suggested changes
Aug 4, 2023
There was a problem hiding this comment.
This doesn't seem to be working yet. It still fails because the delay is exactly 0 so it's never "greater than".
I can't leave a comment there, but you'll need to change L219 to:
assert.GreaterOrEqual(t, duration, tc.minDuration)
assert.LessOrEqual(t, duration, tc.maxDuration)
|
ah thanks for the keen eye, you are right this expression is wrong. |
Windows clocks often don't give microsecond scope reading reliably. Our "strict mode" test was accidentally verifying a lower bound of time spent sleeping, when the important part is the upper bound. This removes the lower bound, so that tests pass on both unix and windows. See dapr#2884 (comment) Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
strict-fix
branch
from
3df9a1c
to
44d7c35
Compare
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 44d7c35 |
This comment was marked as off-topic.
This comment was marked as off-topic.
ItalyPaleAle
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Windows clocks often don't give microsecond scope reading reliably. Our "strict mode" test was accidentally verifying a lower bound of time spent sleeping, when the important part is the upper bound. This removes the lower bound, so that tests pass on both unix and windows.
Issue reference
See #2884 (comment)
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: