Add closer to consul state #3020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
ItalyPaleAle
suggested changes
Aug 1, 2023
There was a problem hiding this comment.
Since this component is stateless and doesn't maintain any persistent connection, I am not sure a closer is needed.
I see the closer that was implemented is only concerned with closing potentially idle TCP sockets... Not sure there's much value in doing that. They'd be closed after a few seconds automatically anyways, and they don't really cause conflicts if the component is destroyed.
|
tested that indeed the time is not even in the seconds range, so would not affect restarts in any meaningful way. will close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a consul closer to shutdown idle connections. Injected default transport into struct to be able to access the transport methods.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #2952
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: