Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consumer proto schema validation for pulsar #3014

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Add consumer proto schema validation for pulsar #3014

merged 5 commits into from
Jul 25, 2023

Conversation

yaron2
Copy link
Member

@yaron2 yaron2 commented Jul 25, 2023

Adds protobuf schema validation for Pulsar consumers.

@yaron2 yaron2 requested review from a team as code owners July 25, 2023 17:52
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 2 nits

m.internalTopicSchemas[topic] = schemaMetadata{
protocol: avroProtocol,
value: v,
}
} else if strings.HasSuffix(k, topicProtoSchemaIdentifier) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total nit, but since we have 3 cases now it may be nice to change this to a switch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

pubsub/pulsar/pulsar_test.go Outdated Show resolved Hide resolved
pubsub/pulsar/pulsar.go Show resolved Hide resolved
ItalyPaleAle
ItalyPaleAle previously approved these changes Jul 25, 2023
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 2 nits

Co-authored-by: Alessandro (Ale) Segala <[email protected]>
Signed-off-by: Yaron Schneider <[email protected]>
@ItalyPaleAle ItalyPaleAle added this to the v1.12 milestone Jul 25, 2023
@ItalyPaleAle ItalyPaleAle added this pull request to the merge queue Jul 25, 2023
Merged via the queue into dapr:master with commit 76b8480 Jul 25, 2023
79 of 84 checks passed
@yaron2 yaron2 deleted the pulsarproto branch July 25, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Protobufs schemas in the Apache Pulsar pubsub component (Ref. #2450 --> #2475)
2 participants