wasm: update benchmark to use url instead of path
#3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edoardo Vacchi <[email protected]>
|
I realized that this minor change was also addressed in this larger PR #2918 |
Signed-off-by: Alessandro (Ale) Segala <[email protected]>
ItalyPaleAle
approved these changes
Jul 20, 2023
|
thanks! Can you please check this one too? dapr/samples#154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edoardo Vacchi [email protected]
Description
#2817 updated to use
urlinstead ofpath, however the companion benchmark was not update. Related: dapr/samples#154Issue reference
I haven't opened an issue since the change is trivial, but will do if requested.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: