Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: update benchmark to use url instead of path #3001

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Jul 20, 2023

Signed-off-by: Edoardo Vacchi [email protected]

Description

#2817 updated to use url instead of path, however the companion benchmark was not update. Related: dapr/samples#154

Issue reference

I haven't opened an issue since the change is trivial, but will do if requested.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@evacchi evacchi requested review from a team as code owners July 20, 2023 13:42
@evacchi
Copy link
Contributor Author

evacchi commented Jul 20, 2023

I realized that this minor change was also addressed in this larger PR #2918

state/requests.go Outdated Show resolved Hide resolved
Signed-off-by: Alessandro (Ale) Segala <[email protected]>
@yaron2 yaron2 added this to the v1.12 milestone Jul 20, 2023
@ItalyPaleAle ItalyPaleAle added this pull request to the merge queue Jul 20, 2023
Merged via the queue into dapr:master with commit 22a695c Jul 20, 2023
83 of 84 checks passed
@evacchi evacchi deleted the wasm-config-fix branch July 21, 2023 07:05
@evacchi
Copy link
Contributor Author

evacchi commented Jul 21, 2023

thanks! Can you please check this one too? dapr/samples#154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants