Fix lint failure for openai binding #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivam Kumar Singh <[email protected]>
|
@ItalyPaleAle Can you take a look. This should fix the lining errors caused in dapr/dapr PR. |
ItalyPaleAle
previously approved these changes
Jul 20, 2023
Perhaps we should have waited for at least a versioned release. Looks like we are still using development builds. |
|
This may be relevant too: Azure/azure-sdk-for-go#21214 |
Signed-off-by: Shivam Kumar Singh <[email protected]>
auto-merge was automatically disabled
July 20, 2023 06:51
Head branch was pushed to by a user without write access
Signed-off-by: Shivam Kumar Singh <[email protected]>
|
@ItalyPaleAle Please have a look. |
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some linting errors that is causing dapr/dapr#6678 to fail.
The OpenAI space is rapidly getting updates so errors like this can be expected.
Issue reference
Please reference the issue this PR will close: #2716
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: