Skip to content

Commit

Permalink
updates as per pr review
Browse files Browse the repository at this point in the history
Signed-off-by: Roberto Rojas <[email protected]>
  • Loading branch information
robertojrojas committed Jul 18, 2023
1 parent 1c84571 commit d726117
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 19 deletions.
19 changes: 2 additions & 17 deletions bindings/aws/s3/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ metadata:
- name: region
required: true
description: |
The AWS region to the instance. See this page for valid regions:
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.RegionsAndAvailabilityZones.html.
The specific AWS region where the S3 bucket is located.
example: '"us-east-1"'
type: string
- name: endpoint
Expand Down Expand Up @@ -85,18 +84,4 @@ metadata:
When connecting to `https://` endpoints, accepts self-signed or invalid certificates.
type: bool
default: 'false'
example: '"true", "false"'
- name: filePath
required: false
description: |
To upload a file from a supplied path (relative or absolute), use the filePath
metadata key on a create request that contains empty data fields.
example: '"mydir/my-test-file.txt"'
type: string
- name: presignTTL
required: false
description: |
To presign an object with a specified time-to-live, use the presignTTL metadata
key on a create request, as a Go duration.
example: '"2h45m"'
type: duration
example: '"true", "false"'
4 changes: 2 additions & 2 deletions bindings/aws/s3/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ type s3Metadata struct {
ForcePathStyle bool `json:"forcePathStyle,string" mapstructure:"forcePathStyle"`
DisableSSL bool `json:"disableSSL,string" mapstructure:"disableSSL"`
InsecureSSL bool `json:"insecureSSL,string" mapstructure:"insecureSSL"`
FilePath string `mapstructure:"filePath"`
PresignTTL string `mapstructure:"presignTTL"`
FilePath string `json:"filePath" mapstructure:"filePath" mdignore:"true"`
PresignTTL string `json:"presignTTL" mapstructure:"presignTTL" mdignore:"true"`
}

type createResponse struct {
Expand Down

0 comments on commit d726117

Please sign in to comment.