Address comments

dapr · Jul 26, 2023 · 4795e83 · 4795e83
1 parent 0c0f87c
commit 4795e83
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/bindings/wasm/output.go b/bindings/wasm/output.go
@@ -89,6 +89,9 @@ func (out *outputBinding) Init(ctx context.Context, metadata bindings.Metadata)
 		return fmt.Errorf("wasm: error instantiating host wasi functions: %w", err)
 	}
 	if _, found := imports[modeWasiHTTP]; found {
+		if out.meta.StrictSandbox {
+			return fmt.Errorf("can not instantiate wasi-http with strict sandbox")
+		}
 		err = wasi_http.Instantiate(ctx, out.runtime)
 	}
 	if err != nil {

diff --git a/bindings/wasm/testdata/http/Makefile b/bindings/wasm/testdata/http/Makefile
@@ -0,0 +1,4 @@
+default: main.wasm
+
+main.wasm: main.go
+	tinygo build -target wasi -o main.wasm main.go
diff --git a/bindings/wasm/testdata/http/main.wasm b/bindings/wasm/testdata/http/main.wasm