Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade edition nft and AllDaySeasonal nft #66

Merged
merged 4 commits into from
Aug 6, 2024
Merged

upgrade edition nft and AllDaySeasonal nft #66

merged 4 commits into from
Aug 6, 2024

Conversation

Deewai
Copy link
Collaborator

@Deewai Deewai commented Aug 6, 2024

No description provided.

@Deewai Deewai requested a review from a team as a code owner August 6, 2024 03:54
loic1
loic1 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@loic1 loic1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just have one question about totalSupply

edition-nft/contracts/AllDaySeasonal.cdc Outdated Show resolved Hide resolved
edition-nft/contracts/EditionNFT.cdc Show resolved Hide resolved
@Deewai Deewai merged commit 77f2f69 into stable-cadence Aug 6, 2024
1 check passed
@Deewai Deewai deleted the deewai/psg-32-editionnft-contract-migration branch August 6, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic1 loic1 loic1 approved these changes

@judezhu judezhu Awaiting requested review from judezhu

@jacksonConrad jacksonConrad Awaiting requested review from jacksonConrad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Deewai @loic1