Add operate entitlement #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Operateentitlement to PackIssuer & PDS admin methods to better reflect that the methods are not meant to be exposed publicly.access(all)as long as the critical security assumption that no capability has been published for the concerned resources is met. The change toaccess(Operate)makes the security assumption more restrictive (i.e., there shouldn't be any published capability withOperateauthorization) but doesn't eliminate it altogether (i.e., the change toaccess(Operate)doesn't guarantee in itself that the security assumption cannot be violated).access(contract)modifier for methods inSharedCapabilitiesandDistInfoto better reflect the access control in place; these objects were already only accessible from within the contract.