added passedByValue samples

danmar · Sep 19, 2024 · 5b81f94 · 5b81f94
1 parent c9bdd30
commit 5b81f94
Show file tree

Hide file tree

Showing 6 changed files with 48 additions and 0 deletions.
diff --git a/samples/passedByValue_1/bad.cpp b/samples/passedByValue_1/bad.cpp
@@ -0,0 +1,11 @@
+class C
+{
+public:
+    explicit C(std::string s)
+    : _s(s)
+    {
+    }
+    void foo();
+private:
+    std::string _s;
+};
diff --git a/samples/passedByValue_1/good.cpp b/samples/passedByValue_1/good.cpp
@@ -0,0 +1,11 @@
+class C
+{
+public:
+    explicit C(std::string s)
+    : _s(std::move(s))
+    {
+    }
+    void foo();
+private:
+    std::string _s;
+};
diff --git a/samples/passedByValue_1/out.txt b/samples/passedByValue_1/out.txt
@@ -0,0 +1,3 @@
+samples\passedByValue_1\bad.cpp:4:28: performance: Function parameter 's' should be passed by const reference. [passedByValue]
+    explicit C(std::string s)
+                           ^
diff --git a/samples/passedByValue_2/bad.cpp b/samples/passedByValue_2/bad.cpp
@@ -0,0 +1,10 @@
+bool foo(std::string s)
+{
+    return s.empty();
+}
+
+int main()
+{
+    std::string s;
+    foo(s);
+}
diff --git a/samples/passedByValue_2/good.cpp b/samples/passedByValue_2/good.cpp
@@ -0,0 +1,10 @@
+bool foo(const std::string& s)
+{
+    return s.empty();
+}
+
+int main()
+{
+    std::string s;
+    foo(s);
+}
diff --git a/samples/passedByValue_2/out.txt b/samples/passedByValue_2/out.txt
@@ -0,0 +1,3 @@
+samples\passedByValue_2\bad.cpp:1:22: performance: Function parameter 's' should be passed by const reference. [passedByValue]
+bool foo(std::string s)
+                     ^