Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: operations base path config option #209

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat: operations base path config option #209

merged 1 commit into from
Aug 2, 2023

Conversation

danielgtaylor
Copy link
Owner

This adds a new config option to override the operation base path when the API base path has a path component.

Also included are some improvements to the config JSON schema to make editing easier with suggested auth params and auth schema name values.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #209 (5a80159) into main (2242e20) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   75.66%   75.62%   -0.04%     
==========================================
  Files          26       26              
  Lines        3550     3553       +3     
==========================================
+ Hits         2686     2687       +1     
- Misses        665      666       +1     
- Partials      199      200       +1     
Files Changed Coverage Δ
cli/apiconfig.go 83.80% <ø> (ø)
cli/api.go 49.20% <50.00%> (-0.39%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2242e20...5a80159. Read the comment docs.

@danielgtaylor danielgtaylor merged commit a50fa39 into main Aug 2, 2023
4 of 6 checks passed
@danielgtaylor danielgtaylor deleted the op-base branch August 2, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant