-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow remote references in open-api specs #202
allow remote references in open-api specs #202
Conversation
1b8edab
to
34f2af6
Compare
@danielgtaylor, just a reminder about this. Are you interested in having this in upstream ? |
FYI, I submitted a patch to the libopenapi which was accepted: pb33f/libopenapi#142 |
34f2af6
to
b9b3421
Compare
b9b3421
to
53eb35b
Compare
@zak905 sorry about the delay, I will look at and test this out ASAP. Any updates to libopenapi require a bunch of testing on my part as I can't break existing customers (we use Restish in a lot of production workflows). The diff looks great, my hesitation now is just around testing / verification with existing OpenAPI specs. |
Thanks for the update @danielgtaylor. In principle, the changes I introduced to libopenapi should preserve the backward compatibility. However, I guess a lot happened since version 0.4, so it's worth double checking, as you said. Concerning the current breaking tests, the cause was some data type changes from int64 to float64 in the github.com/pb33f/libopenapi/datamodel/high/base package. I addressed them in the latest commit, hopefully it should be ok. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 75.37% 75.66% +0.28%
==========================================
Files 26 26
Lines 3513 3550 +37
==========================================
+ Hits 2648 2686 +38
+ Misses 666 665 -1
Partials 199 199
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
closes #203