Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow remote references in open-api specs #202

Closed

Conversation

zak905
Copy link
Contributor

@zak905 zak905 commented Jul 17, 2023

closes #203

@zak905
Copy link
Contributor Author

zak905 commented Jul 31, 2023

@danielgtaylor, just a reminder about this. Are you interested in having this in upstream ?

@zak905
Copy link
Contributor Author

zak905 commented Jul 31, 2023

FYI, I submitted a patch to the libopenapi which was accepted: pb33f/libopenapi#142

@zak905 zak905 force-pushed the support_remote_references_in_openapi branch from 34f2af6 to b9b3421 Compare July 31, 2023 08:29
@zak905 zak905 force-pushed the support_remote_references_in_openapi branch from b9b3421 to 53eb35b Compare July 31, 2023 08:33
@danielgtaylor
Copy link
Owner

danielgtaylor commented Aug 1, 2023

@zak905 sorry about the delay, I will look at and test this out ASAP. Any updates to libopenapi require a bunch of testing on my part as I can't break existing customers (we use Restish in a lot of production workflows).

The diff looks great, my hesitation now is just around testing / verification with existing OpenAPI specs.

@zak905
Copy link
Contributor Author

zak905 commented Aug 2, 2023

Thanks for the update @danielgtaylor. In principle, the changes I introduced to libopenapi should preserve the backward compatibility. However, I guess a lot happened since version 0.4, so it's worth double checking, as you said. Concerning the current breaking tests, the cause was some data type changes from int64 to float64 in the github.com/pb33f/libopenapi/datamodel/high/base package. I addressed them in the latest commit, hopefully it should be ok.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #202 (4f4466f) into main (3a541b4) will increase coverage by 0.28%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   75.37%   75.66%   +0.28%     
==========================================
  Files          26       26              
  Lines        3513     3550      +37     
==========================================
+ Hits         2648     2686      +38     
+ Misses        666      665       -1     
  Partials      199      199              
Files Changed Coverage Δ
openapi/openapi.go 87.91% <100.00%> (ø)
openapi/schema.go 98.43% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a541b4...4f4466f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote references in open api spec documents are not supported
2 participants