Do notation style #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be useful to have a full test with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 14 +1
Lines 962 1014 +52
=========================================
+ Hits 962 1014 +52 ☔ View full report in Codecov by Sentry. |
check69
approved these changes
Mar 29, 2024
check69
reviewed
Mar 29, 2024
rusty_results/prelude.py
Outdated
| :return: Self if self is Some(T) otherwise | ||
| :raises: EarlyReturnException(Empty) | ||
| """ | ||
| ... |
check69
reviewed
Mar 29, 2024
rusty_results/prelude.py
Outdated
| :return: T if self is Ok(T) otherwise | ||
| :raises: EarlyReturnException(Err(e)) | ||
| """ | ||
| ... |
check69
reviewed
Mar 29, 2024
|
|
||
| def test_early_return(): | ||
| @early_return | ||
| def __test_it() -> Option[str]: |
There was a problem hiding this comment.
I would change the __test_it function to accept a parameter and just use the ~parameter and check if it is empty or Some(10) and we get the 100% coverage back again
There was a problem hiding this comment.
Just added the pragma to the line that never reaches.
check69
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a decorator and a operator for using do-notation style of unwraps as per @AlejandroCabeza idea.