Add static method from_optional #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1014 1029 +15
=========================================
+ Hits 1014 1029 +15 ☔ View full report in Codecov by Sentry. |
AlejandroCabeza
approved these changes
Nov 23, 2023
danielSanchezQ
requested changes
Nov 23, 2023
|
|
||
|
|
||
| def test_from_optional(): | ||
| assert Some(0) == OptionProtocol.from_optional(0) |
There was a problem hiding this comment.
I think we should use the type alias Option instead of the protocol for this calls. They are a bad example 😅
There was a problem hiding this comment.
Updated to option_from function.
danielSanchezQ
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the functionality requested by rksouthee. issue #19