Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "request audio transcode format" #987

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from

Conversation

selfhoster
Copy link

Adds menu items in Cache/Network to optionally enable DSub to specify audio transcode format alongside subsonic musicStream requests.

Included options are:

  • raw
  • opus
  • ogg
  • aac
  • mp3
  • m4a
  • flac

This subsonic feature is documented here:

Parameter Required Default Comment
format No   (Since 1.6.0) Specifies the preferred target format (e.g., "mp3" or "flv") in case there are multiple applicable transcodings. Starting with 1.9.0 you can use the special value "raw" to disable transcoding.

Since including format is a part of the 1.6.0 (1.9.0 for raw) subsonic API spec, it is up to subsonic compatible servers that advertise 1.6.0 compliance to correctly handle this.
I have tested this feature with Funkwhale and Airsonic:

  • Funkwhale handles all requested formats apart from aac and m4a correctly (will be opening a seperate issue on their gitlab for this)
  • Airsonic only handles the raw format request correctly but does not break on the other formats (also a separate Airsonic issue)

This pull request should enable Funkwhale as a viable music backend for DSub, and should close:

@daneren2005
Copy link
Owner

daneren2005 commented Oct 9, 2020

Will hopefully finally get around to really checking this out in the next week or so. Been just working my way backwards through PRs since I started working on this again.

@MoritzMaxeiner
Copy link

One thing to add: Neither ogg nor m4a really belong on this list, as they're container formats with several different possible codecs inside, see MoritzMaxeiner@434c125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants