change DELETE rating & skill separator

README.md

@@ -14,33 +14,23 @@ GET /Skills - Get all skills<br>
 GET /Skills/{rating} = Get skill with specified rating<br>
 
 POST /Skills - Add skill
-```json
+```js
 body: {
   "rating": "rating Integer",
   "skill": "skill String"
 }
 ```
 
 PUT /Skills - Update skill rating
-```json
+```js
 body: {
   "oldrating": "current rating Integer",
   "newrating": "new rating Integer",
   "skill": "skill String"
 }
 ```
 
-DELETE /Skills/{skill_id} - Delete selected skill
-```js
-//Skill ID is rating & skill separated by the hash character
-//In JavaScript
-skill_id = encodeURIComponent(`${rating}#${skill}`)
-
-```
-```python
-#In Python
-skill_id = urllib.parse.quote(f"{rating}#{skill}")
-```
+DELETE /Skills/{rating}/{skill} - Delete selected skill
 
 DELETE /Skills/ALL_SKILLS - Delete all skills
 

dynamodb/delete.py

@@ -29,8 +29,15 @@ def lambda_handler(event, context):
     name = unquote(name);
 
     if name != 'ALL_SKILLS':
+        keys = name.split('/')
+        if len(keys) != 2:
+            return respond({
+                'message': 'DELETE required parameter malformed'
+            })
+        sk = '#'.join(keys)
+
         try:
-            table.delete_item(Key={'PK': userid, 'SK': name})
+            table.delete_item(Key={'PK': userid, 'SK': sk})
             response = {'message': 'Skill deleted', 'name': name }
 
         except ClientError as error:
@@ -39,7 +46,7 @@ def lambda_handler(event, context):
             return respond(str(error))
 
         return respond(None, response)
-
+    
     try:
         expression = Key('PK').eq(userid)
         query_results = table.query(KeyConditionExpression=expression)

template.yaml

@@ -156,7 +156,7 @@ Resources:
         Delete:
           Type: HttpApi
           Properties:
-            Path: /Skills/{name}
+            Path: /Skills/{name+}
             Method: delete
             ApiId: !Ref ApiResource