Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Daimo Pay contracts to support bridging with across #1353

Open
wants to merge 7 commits into
base: internal
Choose a base branch
from
Open

New Daimo Pay contracts to support bridging with across #1353

wants to merge 7 commits into from

Conversation

andrewliu08
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daimo-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 6:05pm
daimo-web-stage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 6:05pm

@dcposch dcposch mentioned this pull request Oct 8, 2024
Closed
dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
packages/contract/src/interfaces/IDaimoPayBridger.sol
import "openzeppelin-contracts/contracts/token/ERC20/IERC20.sol";

/// @notice Bridges assets automatically. Specifically, it lets any market maker
/// initiate a bridge transaction to another chain.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
packages/contract/src/pay/DaimoPay.sol Outdated
Comment on lines 92 to 98
function addressToBytes32(address addr) internal pure returns (bytes32) {
return bytes32(uint256(uint160(addr)));
}

function bytes32ToAddress(bytes32 b) internal pure returns (address) {
return address(uint160(uint256(b)));
}
Copy link
Member

@dcposch dcposch Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently specific to CCTP
can delete here

potentially, we can move these to IDaimoPayBridger.sol & generalize that interface to allow 32-byte addresses. this would let us support intents where the destination is eg. on solana, or intents where someone's paying from solana etc

dcposch
dcposch reviewed Oct 8, 2024
View reviewed changes
packages/contract/src/pay/DaimoPay.sol
intentAddr: address(intentContract),
finalRecipient: recipient,
intent: intent
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

dcposch
dcposch approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@dcposch dcposch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGreatTM after comments

Left to do ~

  • Across decision
  • DaimoPayLP testing
  • Test deployment on mainnet base+op+linea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcposch dcposch dcposch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewliu08 @dcposch