Fix createrepo version check #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the version-not-specified and version-greater-than-0.4.6 logic into a single if statement. If either is true, _then_ check if the version is not specified in order to give the error message, but in either case, correctly set the groupfilename.
akikochuchu
approved these changes
Mar 23, 2017
|
This one hit me hard, too. Solved it the same. Please merge this and release a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the version-not-specified and version-greater-than-0.4.6 logic
into a single if statement. If either is true, then check if the
version is not specified in order to give the error message, but in
either case, correctly set the groupfilename.