Fix: Arrays can be printed and modify_field standalone #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A previous update forced the
TunderObject<T>to implementUpcastObject<dyn Any>to be able to print it.However, this trait was never implemented on objects. Arrays can be converted to objects but it's not possible to cast them down to arrays again, because arrays are traits in Rust (dynamic pointers).
Until we wrap arrays with a newtype to cast them back to a regular struct, we can fix the Dafny runtime so that they are still printed as "object"
Second, modify-field!() at the end of a block was triggering parsing issues. I added a block wrapper in the macro to prevent that issue.
How has this been tested?
Two tests added in the runtime.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.