Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce code generator name #4944

Merged

Conversation

keyboardDrummer
Copy link
Member

Description

  • Replace the name Compiler with CodeGenerator, where appropriate.

How has this been tested?

  • It's a refactoring. No additional tests are needed

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

robin-aws
robin-aws previously approved these changes Feb 16, 2024
Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

namespace DafnyCore.Backends.Python;

public static class PythonExtensions {
public static ConcreteSyntaxTree NewBlockPy(this ConcreteSyntaxTree tree, string header = "", string footer = "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice organization improvement


namespace Microsoft.Dafny.Compilers {

class BuilderSyntaxTree<T> : ConcreteSyntaxTree {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this extracted from the Rust backend somewhere?

Copy link
Member Author

@keyboardDrummer keyboardDrummer Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From DafnyCodeGenerator.cs, in the same folder.

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) February 19, 2024 13:49
robin-aws
robin-aws previously approved these changes Feb 19, 2024
robin-aws
robin-aws previously approved these changes Feb 20, 2024
@keyboardDrummer keyboardDrummer merged commit e224127 into dafny-lang:master Feb 22, 2024
19 checks passed
@keyboardDrummer keyboardDrummer deleted the introduceCodeGeneratorName branch February 22, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants