-
Notifications
You must be signed in to change notification settings - Fork 262
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolve potential concurrency bug in TestNotificationReceiver, improv…
…ing test stability (#5310) I was inspired by this unstable test failure: #5309 to find and fix this concurrency issue. ### Description - Resolve potential concurrency bug in TestNotificationReceiver. Here's the code and an explanation of the potential issue: ``` public TNotification GetLast(Func<TNotification, bool> predicate) { var result = History.LastOrDefault(predicate); // if another threads add an item at this point, then history returns a non-last item, and the queue will be emptied in the next statement, so waiting for a new item, which the consuming code may do because history returned a non-last item, might time out. ClearQueue(); return result; } ``` ### How has this been tested? - No idea how to test this <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
- Loading branch information
1 parent
a4972f5
commit 62a00c7
Showing
6 changed files
with
37 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters