Make the error reporter for checking if Z3 is available, more consist…

…ent (#5086)

Fixes #5067
### Description
Make the error reporter for checking if Z3 is available, more consistent
between the IDE and various CLI commands

### How has this been tested?
Updated CLI and IDE tests

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>

Source/DafnyCore.Test/DooFileTest.cs

@@ -11,6 +11,7 @@ public void RoundTripCurrentVersion() {
     var options = DafnyOptions.Default;
     options.ApplyDefaultOptionsWithoutSettingsDefault();
     var program = ParseProgram("module MyModule { function TheAnswer(): int { 42 } }", options);
+    options.ProcessSolverOptions(program.Reporter, Token.Cli);
     var dooFile = new DooFile(program);
 
     var path = Path.GetTempFileName();

Source/DafnyCore/AST/Expressions/Conditional/Patterns/IdPattern.cs

@@ -33,11 +33,9 @@ public IdPattern(Cloner cloner, IdPattern original) : base(cloner.Tok(original.T
     Id = original.Id;
     Arguments = original.Arguments?.Select(cloner.CloneExtendedPattern).ToList();
     HasParenthesis = original.HasParenthesis;
+    Type = cloner.CloneType(original.Type);
     if (cloner.CloneResolvedFields) {
       BoundVar = cloner.CloneIVariable(original.BoundVar, false);
-      Type = original.Type;
-    } else {
-      Type = new InferredTypeProxy();
     }
   }
 
@@ -54,7 +52,7 @@ public IdPattern(IToken tok, String id, Type type, List<ExtendedPattern> argumen
     Contract.Requires(id != null);
     Contract.Requires(arguments != null); // Arguments can be empty, but shouldn't be null
     this.Id = id;
-    this.Type = type == null ? new InferredTypeProxy() : type;
+    this.Type = type ?? new InferredTypeProxy();
     this.Arguments = arguments;
     this.IsGhost = isGhost;
   }