Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sniffer): remove useless EOF warning logs printing #650

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(sniffer): remove useless EOF warning logs printing #650

merged 1 commit into from
Sep 25, 2024

Conversation

douglarek
Copy link
Contributor 

level=warning msg="handleConn: %!w(<nil>): EOF"
...

In my opinion, these logs are quite useless.

Background

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@douglarek
fix(sniffer): remove useless EOF warning logs printing
c157c2b 
`level=warning msg="handleConn: %!w(<nil>): EOF"` ...
@douglarek douglarek requested a review from a team as a code owner September 25, 2024 07:12
mzz2017
mzz2017 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

dae-prow[bot]
dae-prow bot approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit da8890c into daeuniverse:main Sep 25, 2024
26 checks passed
@douglarek douglarek deleted the fix-logs branch September 25, 2024 07:17
@dae-prow dae-prow bot mentioned this pull request Sep 27, 2024
Closed
@dae-prow dae-prow bot mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

@mzz2017 mzz2017 mzz2017 approved these changes

Assignees

@douglarek douglarek

Labels
fix tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglarek @mzz2017