-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support bandwidth configuration #645
Conversation
提问,
|
否,Hysteria2 协议会在握手时协商双方带宽。我们实现的行为是:如果服务端和客户端任意一方不提供带宽或者服务端选择忽略客户端带宽,那么它将会选择启用 BBR。只有当双方均设置了带宽的前提下才会取双方最小的带宽进行通信,具体流程在 上游 Hysteria 文档中有描述。
实际上确实有可能存在「服务端和客户端都提供了带宽参数,但是实际上不支持 Brutal」的情况,且根据协议这似乎是一个 Unspecified Behavior。但是由于我们的协商行为和官方客户端一致,所以当这种这种情况存在时,则该服务端将和一般通过官方客户端的互操作性也会难以保证,所以我们大概可以忽略这种情况。 |
@mnixry 我不是一个 hy2 用户,但你解释的非常清楚,且对于我了解 PR 相关的风险非常重要,多谢解答 |
@mnixry 麻烦在 pr 描述中也加入配置文件的示例,谢谢 |
done |
474f55c
to
f868f06
Compare
Since daeuniverse/outbound#21 is merged, consider to update go.mod and be ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧪 Since the PR has been fully tested, please consider merging it.
@mnixry LGTM! Thanks for your contribution! Are you ready to merge? |
Background
ref: daeuniverse/outbound#21
Checklist
Full Changelogs
Implement bandwidth config parsing in dae:
Improve handling for
insecure
parameter in hysteria2 URI parsing.Issue Reference
Closes #[issue number]
Test Result