feat(trace): add drop-only option #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linglilongyi
force-pushed
the
drop-only
branch
from
3d6838c
to
addf3cf
Compare
jschwinger233
requested changes
Sep 25, 2024
| switch sym.Name { | ||
| case "__kfree_skb","kfree_skbmem": | ||
| // most skb end in the call of kfree_skbmem | ||
| if !dropOnly || slices.Contains(skb2symNames[event.Skb],"kfree_skb_reason") { |
There was a problem hiding this comment.
所以就算不 drop only 现在也会按照 skb 聚合、等 kfree 再输出。应该也没问题。
There was a problem hiding this comment.
确实改变了原来的行为模式，我在changelog里补充一下
- refactor: also merge some line to simplify the code
jschwinger233
approved these changes
Sep 26, 2024
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
|
@linglilongyi @jschwinger233 是否已经 ready to merge？ |
|
yes in my opinion |
sumire88
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#524
Currently
dae tracedumps huge amount of packets, most of them are not necessary. In most cases, we care about packets that are dropped by kernel, aka processed by kernel functionkfree_skb_reason, or called bykfree_skbmembut withoutconsume_skb.Checklist
Full Changelogs
--drop-onlyoption to where dae only prints the packets dropped by kernel.dae tracenow print all the skbs of a packet until the packet is freed by kernel, whether it runs with--drop-onlyor not.Issue Reference
Closes #524
Test Result
start tracing
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 tcp_v4_early_demux
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 ip_route_input_noref
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 ip_route_input_slow
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 fib_validate_source
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 __fib_validate_source
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 ip_local_deliver
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 ip_local_deliver_finish
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 ip_protocol_deliver_rcu
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 raw_local_deliver
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 tcp_v4_rcv
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 tcp_v4_fill_cb
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 tcp_timewait_state_process
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 tcp_v4_send_ack
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 ip_send_unicast_reply
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 __ip_options_echo
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 security_skb_classify_flow
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 bpf_lsm_xfrm_decode_session
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 kfree_skb_reason(SKB_DROP_REASON_NOT_SPECIFIED)
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 skb_release_head_state
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 skb_release_data
ffff9e800e629d00 mark=0 netns=4026531840 if=2(ens18) proc=735(/usr/bin/dae) 142.250.197.174:80 > 192.168.1.101:33334 tcp_flags=.F payload_len=0 kfree_skbmem