Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: replace c arithmetic operators with bitwise ones #628

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Integral-Tech
Copy link
Contributor

Background

It is better to use bitwise operators instead of arithmetic ones when merging bit fields.

Checklist

Full Changelogs

  • Replace C arithmetic operators with bitwise ones to improve performance

Test Result

Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzz2017 mzz2017 added the tested label Sep 13, 2024
@mzz2017 mzz2017 changed the title perf: replace c arithmetic operators with bitwise ones optimize: replace c arithmetic operators with bitwise ones Sep 13, 2024
@mzz2017 mzz2017 merged commit e637d66 into daeuniverse:main Sep 13, 2024
27 checks passed
@Integral-Tech Integral-Tech deleted the perf-bitwise branch September 13, 2024 14:41
@dae-prow dae-prow bot mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants