Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tutorials): add dae-with-opnsense(en/zh) #438

Merged
merged 2 commits into from
Jan 23, 2024
Merged

docs(tutorials): add dae-with-opnsense(en/zh) #438

merged 2 commits into from
Jan 23, 2024

Conversation

troubadour-hell
Copy link
Contributor

Background

Checklist

Full Changelogs

  • [Add docs for use dae with OPNsense]

Issue Reference

Closes #[issue number]

Test Result

@troubadour-hell troubadour-hell requested a review from a team as a code owner January 23, 2024 09:09
@dae-prow dae-prow bot added the documentation Improvements or additions to documentation label Jan 23, 2024
sumire88
sumire88 previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@sumire88 sumire88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Amazing work! Thanks!

@sumire88
Copy link
Contributor

sumire88 commented Jan 23, 2024 •
edited
Loading

@troubadour-hell Could you also fix the linting issue, please? You may check out details in the Check Documents check.

@sumire88 sumire88 merged commit c26169d into daeuniverse:main Jan 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumire88 sumire88 sumire88 approved these changes

Assignees

@troubadour-hell troubadour-hell

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@troubadour-hell @sumire88