fix/docs: fix the first check failure and possible dns leaking #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dae-prow
bot
added
documentation
mzz2017
changed the title
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
piyoki
reviewed
Jan 8, 2024
Comment on lines
+152
to
+169
| # routing { | ||
| # # According to the request of dns query, decide to use which DNS upstream. | ||
| # # Match rules from top to bottom. | ||
| # request { | ||
| # # fallback is also called default. | ||
| # fallback: alidns | ||
| # } | ||
| # # According to the response of dns query, decide to accept or re-lookup using another DNS upstream. | ||
| # # Match rules from top to bottom. | ||
| # response { | ||
| # # Trusted upstream. Always accept its result. | ||
| # upstream(googledns) -> accept | ||
| # # Possibly polluted, re-lookup using googledns. | ||
| # ip(geoip:private) && !qname(geosite:cn) -> googledns | ||
| # # fallback is also called default. | ||
| # fallback: accept | ||
| # } | ||
| # } |
There was a problem hiding this comment.
Considered this is the advanced use cases. Shall we put them in https://github.com/daeuniverse/dae/blob/main/docs/en/configuration/routing.md?
We may create a separate block to include the proposed changes aboved.
3 tasks
sumire88
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When local dns server is listening at :53 and resolv.conf points to it, the first connectivity check will fail. This is because when we use the local dns server to resolve the domain name of the node, the dae is not yet listening, but the ebpf program has been installed and dns request is redirected to dae, so the first dns request will fail.
If we add local dns servers to must_direct list, dns leaking possibly occurs.
Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result