Allowing Spinner to keep height on redraw + delaying spinner show (avoid too many or too quick show/hide cycle) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to keep currrent output height, and have some delay before showing spinner (and if a hide comes before delay, it doesnt show at all)
|
Hi @rgriffogoes thanks a lot for the initiative! I haven't taken a close look yet, but I do notice that this PR is for two separate features. Could you please submit two separate PRs, one for each issue? |
|
@rgriffogoes Could you edit this PR to only contain the code relevant for "keep height on redraw" please? |
|
@rgriffogoes I want to do some cleanup of old PRs - do you think you'll have time in 2023 to resolve this PR, or should we abandon it? |
|
For cleaner history and to better understand the PR, it'd be helpful if each of the features you added will have its own PR |
|
@rgriffogoes Let me know if you want to keep this PR alive! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new features: set spinner to keep currrent output height, and have some delay before showing spinner (and if a hide comes before delay, it doesnt show at all).
These features are configurable by keep.height and show.delay properties.
Default values should behave almost* the same as before: with a 0 delay timeout function it can be that the show/hide cycle behaves differently, but on my understanding it would behave better (e.g.: if somehow the hide spinner happens immediately after the display, nothing will happen while before the change the dom would be affected twice)