ci(workflow): ensure relative_url is used #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
force-pushed
the
ci/workflow/ensure-relative_url-is-used
branch
from
db09647
to
df71f8d
Compare
|
How can I reproduce the issue that you were having? |
|
I understand this now, thanks! |
mbobcik
pushed a commit
to mbobcik/BoBlog
that referenced
this pull request
Oct 31, 2024
jlbrooks
added a commit
to jlbrooks/jlbrooks.github.io
that referenced
this pull request
Nov 5, 2024
* Add Mastodon profile verification (daattali#933) See https://docs.joinmastodon.org/user/profile/#fields * Add New Comment options (daattali#960) * Init dev branch * Fix dev branch * Forgot to add commentbox.html * Testing discussbot integration * forgot comments.html * remove my credentials * Update _config.yml Change comments to offer unambiguous descriptions of variables. * remove discussbot * Update CHANGELOG.md Co-authored-by: Karsten Ng <[email protected]> * add commentbox to readme * add commentbox to readme * adding kaggle social link (daattali#961) * Update social-networks-links.html * Update _config.yml * add news item for kaggle social media * added hackerrank social media network (daattali#978) * add news item for hacerrank * Markup home page content lists and tags as lists (daattali#950) * Markup home page content lists and tags as lists * Fix styling after markup changes * Fix typo * fix a couple visual issues * make sure the divider line between posts shows up Co-authored-by: Dean Attali <[email protected]> * Update CHANGELOG.md * add 'edit this page' button; closes daattali#1004 * Fixes daattali#765 (daattali#1010) * Fixes daattali#765 * Update beautifuljekyll.css * Update beautifuljekyll.css Co-authored-by: Dean Attali <[email protected]> * Update CHANGELOG.md * more readable format for config file * Add `navbar-var-length` config parameter (daattali#1011) * add navbar-var-length config option * fix endif -> endunless * replaced var with const (daattali#1049) * trigger GH actions * update actions/checkout to v3 because of node deprecation warning; fixes daattali#1099 * google analytics config setting: encourage gtag, discourage google_analytics (fixes daattali#1096) * Discord supports old and new invite code styles (daattali#1135) * remove cover image * Delete index.html * Update README.md * new github workflow instructions * Update README.md * Add files via upload * remove sponsor * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * replace var with let or const in javascript; fixes daattali#1048 * update readme * update gem versions to what GitHub Pages uses * Update LICENSE * Update base.html * Update beautifuljekyll.js * add webrick to gemspec because it isnt included in ruby3 anymore * Update README.md * Update README.md * Update README.md * show warning message if old Universal Analytics is used * format changelog for v6 * Update CHANGELOG.md * update gemspec to version 6 * bump hotfix version to allow gems to use any jekyll version and to use webrick in runtime rather than only in dev * google analytics message: add padding around * be explicit about jekyll version to fix github action * Update beautiful-jekyll-theme.gemspec * Update beautiful-jekyll-theme.gemspec * Update README.md * Allow changing the order of the social network links that appear in the footer; fixes daattali#1152 * Update issue_template.md * fixed bug where hovering over search results showed the string {desc}; fixes daattali#1156 * Add GitLab to the list of social media sources (daattali#1168) * Add GitLab to the list of social media sources * Update CHANGELOG.md --------- Co-authored-by: Dean Attali <[email protected]> * remove unneeded images * Rename 2020-02-28-test-markdown.md to 2020-02-28-sample-markdown.md * Update 2020-02-28-sample-markdown.md * Add files via upload * Update CHANGELOG.md * readme: link to sample markdown post * Update README.md * remove duplicate css * add support for header-extra parameter * Add sponsor to readme * Add Bluesky to social network links (daattali#1218) * fix google scholar link construction (daattali#1187) (daattali#1189) * Add robots.txt (daattali#1224) * Update robots.txt * Delete robots.txt * pagination: change arrows to fontawesome and dont show text on small screens * Update CHANGELOG.md * use slash instead of empty string for absolute url, try to fix links in 'jekyll build' * Add support for author in YAML parameters (daattali#1220) * Made the footer stick to the bottom; fixes daattali#576 (daattali#1226) * post navigation: move arrow to correct location * page naviation: move arrow to correct location * bug fix: escape characters in url in searchjson; fixes daattali#1232 * simplify header html; alternative to daattali#1227 * change role=main to main tag * fix layouy bug where code blocks dont scroll horizontally; fixes daattali#1235 * Update README.md * update default youtube string in footer * add support for favicon.ico file; related to daattali#1234 and daattali#1249 * Yelp url bug fix (daattali#1259) (daattali#1260) * Add itch.io social network link to the commented out entries (daattali#1268) * Add a title-on-all-pages site option (daattali#1272) * Update _config.yml * Updated Search Bar (daattali#1265) * Relax version constraint for kramdown to support latest version of github-pages (daattali#1290) * Fix GitHub Actions for Jekyll 4.x (daattali#1276) * github action: update checkout to latest v4 * Added Whatsapp to social network (daattali#1299) * Update CHANGELOG.md * add mathjax YAML parameter to support mathjax expressions; closes daattali#195 * feat(social): add untappd (daattali#1307) * Update CHANGELOG.md * Use CSS variables; fixes daattali#661 (daattali#1312) * add missing semicolons in css * readme: add next step to read jekyll docs * upgrade fontawesoem to 6.5.2; fixes 1330 * change twitter icon to X; fixes daattali#1193 * escpe backslash in search results; fixes daattali#1279 * move search to its own file; fixes 1284 * feat(social-links): allow subreddit (daattali#1371) * update changelog * ci(workflow): ensure relative_url is used (daattali#1374) --------- Co-authored-by: Stefan Leibfarth <[email protected]> Co-authored-by: Karsten Ng <[email protected]> Co-authored-by: Karsten Ng <[email protected]> Co-authored-by: Dean Attali <[email protected]> Co-authored-by: 洪健翔 Hung, Chien-Hsiang <[email protected]> Co-authored-by: tanersekmen <[email protected]> Co-authored-by: Dean Attali <[email protected]> Co-authored-by: Jefferson Bledsoe <[email protected]> Co-authored-by: Arnaud Dagnelies <[email protected]> Co-authored-by: Vincent Tam <[email protected]> Co-authored-by: Nico is LOST <[email protected]> Co-authored-by: Alejandro G. Vallejo <[email protected]> Co-authored-by: Alex Chohlas-Wood <[email protected]> Co-authored-by: Richard Decal <[email protected]> Co-authored-by: Stephen Schwetz <[email protected]> Co-authored-by: Stephen Schwetz <[email protected]> Co-authored-by: ch0c0l8ra1n <[email protected]> Co-authored-by: tsolloway <[email protected]> Co-authored-by: Chadow <[email protected]> Co-authored-by: Quinn <[email protected]> Co-authored-by: Taranjeet Singh Bedi <[email protected]> Co-authored-by: Daniel <[email protected]> Co-authored-by: Adam Setch <[email protected]> Co-authored-by: ReenigneArcher <[email protected]> Co-authored-by: Jacob Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI build does not respect the
relative_urlproperty when building from a "project" repo instead of the.github.ionamed repo.Fixes #1373
The changes are derived from the examples here (https://github.com/actions/jekyll-build-pages) and were tested here (ReenigneArcher#3). A small bug was found where those changes would not run certain plugins, such as those in a
_pluginsdirectory, so I reverted some of the changes, and made some tweaks in ReenigneArcher#4. The changes in this repo are slightly different than from those two PRs, as the the deploy step is omitted.The majority of people using beautiful-jekyll will probably never notice this issue because they are probably either using the repo named
.github.ioor are not using the workflow to build and deploy the pages.Evidence of functionality: https://reenignearcher.github.io/beautiful-jekyll/ (I am deploying from the CI workflow, not from a branch) https://github.com/ReenigneArcher/beautiful-jekyll/actions/runs/10823491697