feat: add goroutine watcher #16
Conversation
| @@ -53,8 +64,9 @@ type autoPprof struct { | |||
| reportBoth bool | |||
There was a problem hiding this comment.
This field is an option that is only valid when monitoring only two things, CPU and memory, and as the runtime monitor increases, its meaning becomes less meaningful.
@mingrammer Please give me your opinion on how to remove it in a separate version!
There was a problem hiding this comment.
We should introduce a new option, reportAll, which reports all profile results when any threshold is exceeded. And deprecate the reportBoth.
There was a problem hiding this comment.
Good idea! I will create this idea as a separate PR.
jake-shin0
changed the title
| @@ -858,13 +1020,13 @@ func BenchmarkLightJob(b *testing.B) { | |||
|
|
|||
| func BenchmarkLightJobWithWatchCPUUsage(b *testing.B) { | |||
There was a problem hiding this comment.
i think we need to benckmark goroutine watcher too.
There was a problem hiding this comment.
I artificially created a lot of goroutines and ran a benchmark test. This is my first time doing a test like this. What should I fix?
BenchmarkLightAsyncJob-5 376760 32056 ns/op 7040 B/op 352 allocs/op
BenchmarkLightAsyncJobWithWatchGoroutineCount-5 350994 33689 ns/op 7040 B/op 351 allocs/op
BenchmarkHeavyAsyncJob-5 414 29095456 ns/op 6001969 B/op 300096 allocs/op
BenchmarkHeavyAsyncJobWithWatchGoroutineCount-5 403 29474789 ns/op 5972177 B/op 298607 allocs/op
| func (s *SlackReporter) ReportGoroutineProfile( | ||
| ctx context.Context, r io.Reader, gi GoroutineInfo, | ||
| ) error { | ||
| hostname, _ := os.Hostname() // Don't care about this error. |
There was a problem hiding this comment.
p999; I think this comment is vague, how about just removing it?
| @@ -53,8 +64,9 @@ type autoPprof struct { | |||
| reportBoth bool | |||
There was a problem hiding this comment.
We should introduce a new option, reportAll, which reports all profile results when any threshold is exceeded. And deprecate the reportBoth.
|
@mingrammer |
queryerwas managed as a separate dir and its implementation was divided. (cgroup & runtime)Queryerinterface method to public.queryer, I also wanted to manageprofilerin dir, but I did not consider this part.queryerandprofiler, but did not do so.ticker, so pprof lib is used in bothqueryerandprofiler.