error corrections

cran-comments.md

@@ -2,14 +2,13 @@
 
 This is a resubmission after receiving comments from CRAN
 
-New submission
-because package was archived on CRAN
+New submission because package was archived on CRAN
 Archived on 2023-11-29 because issues were not corrected in time.
 
 ## Test environments
 * local macOS X 14.4.1, R version 4.3.0
 * CRAN win-builder https://win-builder.r-project.org, R version 4.4.0
-* rhub workflow for Linux, old macOS and Windows
+* rhub::rhub_check() workflow for Linux, old macOS and Windows
 
 ## R CMD check results
 0 errors ✔ | 0 warnings ✔ | 0 notes ✔
@@ -18,12 +17,13 @@ Archived on 2023-11-29 because issues were not corrected in time.
 checked via revdepcheck::revdep_check() on local macOS X 14.2.1
 No problems found
 
-Comments to package review:
+## Actions taken after package review:
 
-- corrected DESCRIPTION
+- I have corrected the DESCRIPTION-file
 - There are indeed literature references in the Rd-files of this package, but they are very specific to individual functions. It does not seem fitting to elevate them to the main DESCRIPTION file.
-- removed most "\dontrun" because with more modern computers many calculations dropped below 5 sec.
-- changed most remaining examples of "\dontrun" into "\donttest". Only real examples of errors remain as "\dontrun"
-- there are two remaining example sections with slightly over 5 second runtime
-- removed unexecutable code (forgotten leftover from earlier attempts)
-- changed resetting of user's options to a more resilient approach: oldpar<-par("mfrow")...par(mfrow=oldpar)
+- I removed most "\dontrun" because with more modern computers many calculations dropped below 5 sec.
+- I changed most remaining examples of "\dontrun" into "\donttest". 
+- Only real examples of errors remain as "\dontrun": either examples of limits to the computations, or a few graphics that raise errors on some platforms because of Unicode non-compliance.
+- there are two remaining example sections with slightly over 5 seconds runtime on my computer
+- I removed unexecutable code (forgotten leftover from earlier attempts)
+- I changed resetting of user's options to a more resilient approach: oldpar<-par("mfrow")...par(mfrow=oldpar)

man/sim.wordlist.Rd

@@ -91,9 +91,10 @@ data(huber)
 # the rest does not really influence the time needed
 system.time( sim <- sim.lang(huber, method = "p") )
 
-\donttest{
 # a simple distance-based UPGMA tree
-# note non-ASCII characters in data might lead to plot errors
+
+\dontrun{
+# note non-ASCII characters in data might lead to plot errors on some platforms
 plot(hclust(as.dist(-sim), method = "average"), cex = .7)
 }
 
@@ -110,13 +111,17 @@ adj <- c(1,5,13,14,28,35,40,48,67,89,105,106,120,131,137,146,148,
 	294,300,309,341,353,355,359)
 
 # show them as trees
+
+\dontrun{
+# note non-ASCII characters in data might lead to plot errors on some platforms
 oldpar<-par("mfrow")
 par(mfrow = c(1,2)) 
 plot(hclust(as.dist(-simB[adj,adj]), method = "ward.D2"), 
 	cex = .5, main = "bigrams")
 plot(hclust(as.dist(-simC[adj,adj]), method = "ward.D2"), 
 	cex = .5, main = "colexification")
 par(mfrow = oldpar)
+}
 
 # ----- similarity between graphemes -----
 
@@ -133,8 +138,8 @@ X$GG <- drop0(X$GG, tol = 1)
 colnames(X$GG) <- rownames(X$GG)
 correspondences <- X$GG[X$GD[,"bora"],X$GD[,"muinane"]]
 
-\donttest{
-# note non-ASCII characters in data might lead to plot errors
+\dontrun{
+# note non-ASCII characters in data might lead to plot errors on some platforms
 heatmap(as.matrix(correspondences))
 }
 }

man/splitWordlist.Rd

@@ -147,8 +147,8 @@ GD <- H$GS \%*\% H$SW \%*\% t(H$DW)
 colnames(GD) <- H$doculects
 correspondences <- G[GD[,"bora"],GD[,"muinane"]]
 
-\donttest{
-# this might lead to errors because of non-ASCII symbols
+\dontrun{
+# this might lead to errors on some platforms because of non-ASCII symbols
 heatmap(as.matrix(correspondences))
 }
 }